Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: peer resolutions, limit example workspaces #1816

Merged
merged 2 commits into from
Apr 1, 2021

Conversation

acao
Copy link
Member

@acao acao commented Mar 28, 2021

this provides more targeted peer resolutions, based on known compatibility. graphql@14.5.0 is when built-in graphql types are required. the last 14.4.x release before that also added a new method that we use.

this also limits the scope of the workspaces to monaco, so that both start commands work, and the yarn lockfile can shrink in size and duplicate resolution complexity because of create-react-app/etc in other examples

prompts for review:

  1. should we add || experimental-defer-stream?
  2. does not adding it create peer resolution problems for consumers? webpack example should be representative of that?
  3. there is a project called manypkg that has a fix command that will normalize the dependency versions of all the workspaces, preventing issues with clashing versions. it will resolve to the highest version, and has a rule to automatically add the peer dependencies as a devDependency. we can include another commit to this PR with this fix, which would require some type fixes in language server because of babel versions in findGraphQLTags . this could also be another PR, but naturally makes sense as the next step after this PR

@changeset-bot
Copy link

changeset-bot bot commented Mar 28, 2021

🦋 Changeset detected

Latest commit: f53945f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
codemirror-graphql Patch
graphiql Patch
@graphiql/toolkit Patch
graphql-language-service Patch
graphql-language-service-cli Patch
graphql-language-service-interface Patch
graphql-language-service-parser Patch
graphql-language-service-server Patch
graphql-language-service-types Patch
graphql-language-service-utils Patch
monaco-graphql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Mar 28, 2021

Codecov Report

Merging #1816 (f53945f) into main (4e830ce) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1816   +/-   ##
=======================================
  Coverage   65.66%   65.66%           
=======================================
  Files          85       85           
  Lines        5115     5115           
  Branches     1635     1635           
=======================================
  Hits         3359     3359           
  Misses       1752     1752           
  Partials        4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e830ce...f53945f. Read the comment docs.

@acao acao changed the title fix: fix peer resolutions, limit example workspaces fix: peer resolutions, limit example workspaces Mar 28, 2021
@acao acao force-pushed the fix/peer-resolutions-graphql-15 branch from 297fba5 to 5241fe5 Compare March 29, 2021 01:48
@imolorhe
Copy link
Contributor

Welcome back 🙂

@acao
Copy link
Member Author

acao commented Mar 29, 2021

thanks @imolorhe !! excited to be back! I'll be contributing more some evenings this week and weekend. I really really appreciate your co-maintainership during my hiatus!

@acao acao merged commit 6869ce7 into main Apr 1, 2021
@acao acao deleted the fix/peer-resolutions-graphql-15 branch April 1, 2021 21:43
@github-actions github-actions bot mentioned this pull request Apr 1, 2021
@simkessy
Copy link

simkessy commented Apr 13, 2021

This is breaking builds

image

@jay-deshmukh
Copy link

jay-deshmukh commented Apr 28, 2021

Temporary Solution

adding

"resolutions": {
    "graphql-language-service-parser": "1.9.0",
    "graphql-language-service-interface": "2.8.2"
  }
  

to package.json fixed the build errors for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants