Move @graphiql/create-fetcher to @graphiql/toolkit #1788
Conversation
🦋 Changeset detectedLatest commit: ec16590 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
harshithpabbati
force-pushed
the
toolkit
branch
2 times, most recently
from
ce3aeed
to
082de9b
Compare
harshithpabbati
force-pushed
the
toolkit
branch
from
082de9b
to
3c4dd35
Compare
|
awesome work! can you add to the readme for create fetcher that it was inspired by graphql-subscriptions-fetcher, and thank @Urigo? |
harshithpabbati
force-pushed
the
toolkit
branch
from
c222dfc
to
d82dc4b
Compare
harshithpabbati
force-pushed
the
toolkit
branch
3 times, most recently
from
ed515c2
to
0cf0f87
Compare
|
oh hmm, I don't think we're going to be removing the package in this PR. remember we're going to leave it in with the readme pointing to toolkit for one last release? |
|
If the number of packages using it isn't a lot yet, then it should be fine to delete it? Else i think updating the readme that the functionality has been moved should be fine as well. |
|
@imolorhe yes, graphiql is only in rc with it. ok sounds good! wish we’d thought of this before i announced it thanks so much @harshithpabbati ! |
harshithpabbati
force-pushed
the
toolkit
branch
from
0cf0f87
to
606cdd1
Compare
|
@imolorhe I’ve been meaning to get to this one and its holding up the next RC. if you could take a look that would be awesome! |
| @@ -13,7 +13,7 @@ import { | |||
| createWebsocketsFetcherFromUrl, | |||
| createMultipartFetcher, | |||
| createSimpleFetcher, | |||
| } from '../lib'; | |||
| } from '../../dist/lib'; | |||
There was a problem hiding this comment.
This change should not be necessary
| import { | ||
| isSubscriptionWithName, | ||
| createWebsocketsFetcherFromUrl, | ||
| } from '../../dist/lib'; |
There was a problem hiding this comment.
This change should not be necessary.
harshithpabbati
force-pushed
the
toolkit
branch
from
fff875f
to
10921db
Compare
Codecov Report
@@ Coverage Diff @@
## main #1788 +/- ##
==========================================
+ Coverage 65.61% 65.66% +0.05%
==========================================
Files 85 85
Lines 5115 5115
Branches 1624 1624
==========================================
+ Hits 3356 3359 +3
+ Misses 1755 1752 -3
Partials 4 4
Continue to review full report at Codecov.
|
Co-authored-by: Samuel <samuelimolo4real@gmail.com> Co-authored-by: Rikki <rikki.schulte@gmail.com>
Moving create fetcher functionalites into toolkit