fix: crash on receiving an LSP message in "stream" mode #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1710 +/- ##
==========================================
+ Coverage 63.80% 65.26% +1.45%
==========================================
Files 86 86
Lines 4694 4698 +4
Branches 1258 1261 +3
==========================================
+ Hits 2995 3066 +71
+ Misses 1441 1382 -59
+ Partials 258 250 -8
Continue to review full report at Codecov.
|
|
fantastic, thank you! |
|
There might be an issue with |
|
Fixed with the latest commit. Feel free to squash all commits on merging. (Also noticed that when schema server is not running, that will trigger an unhandled exception but I'll handle that in a separate PR). |
Don't write log messages to stdout in "stream" mode. stdout is reserved for communicating with the LSP client in the "stream" mode. Write all types of log messages to stderr. Fixes LSP server crashing on the first message it receives (or maybe LSP client closing it because it received an invalid response). Also: - the callback to socket.write() was always logging the "err" parameter even if there was undefined which caused spurious lines in the console. Only actually log that if "err" is truthy. - Avoid too many newlines at the end of the log message as that also causes spurious empty lines in the log and the console. - Gracefully handle the case when the response for "workspace/configuration" returns a null value. Those configuration options have sane defaults and don't need to be present. - The Logger._stream property was removed as it was unused. Resolves graphql#1708
rchl
force-pushed
the
fix/stream-mode
branch
from
9fab65c
to
f28ff4e
Compare
|
fabulous work, looks good to merge. thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't write log messages to stdout in "stream" mode. stdout is reserved
for communicating with the LSP client in the "stream" mode. Write all
types of log messages to stderr.
Fixes LSP server crashing on the first message it receives (or maybe
LSP client closing it because it received an invalid response).
Also:
even if there was undefined which caused spurious lines in the
console. Only actually log that if "err" is truthy.
causes spurious empty lines in the log and the console.
returns a null value. Those configuration options have sane defaults
and don't need to be present.
Resolves #1708