gently trap graphql parse errors in the LS and LSP

I introduced these accidentally and they have caused a lot of issues!
graphql · Apr 26, 2022 · d22f611 · d22f611
1 parent ee77792
commit d22f611
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 11 deletions.
diff --git a/.changeset/wise-birds-notice.md b/.changeset/wise-birds-notice.md
@@ -0,0 +1,6 @@
+---
+'graphql-language-service': patch
+'graphql-language-service-server': patch
+---
+
+Trap all graphql parsing exceptions from (relatively) newly added logic. This should clear up bugs that have been plauging users for two years now, sorry!
diff --git a/packages/graphql-language-service-server/src/MessageProcessor.ts b/packages/graphql-language-service-server/src/MessageProcessor.ts
@@ -690,12 +690,13 @@ export class MessageProcessor {
     }
 
     const inlineFragments: string[] = [];
-
-    visit(parse(query), {
-      FragmentDefinition: (node: FragmentDefinitionNode) => {
-        inlineFragments.push(node.name.value);
-      },
-    });
+    try {
+      visit(parse(query), {
+        FragmentDefinition: (node: FragmentDefinitionNode) => {
+          inlineFragments.push(node.name.value);
+        },
+      });
+    } catch {}
 
     const formatted = result
       ? result.definitions.map(res => {

diff --git a/packages/graphql-language-service/src/interface/getAutocompleteSuggestions.ts b/packages/graphql-language-service/src/interface/getAutocompleteSuggestions.ts
@@ -79,11 +79,15 @@ export const SuggestionCommand = {
 const collectFragmentDefs = (op: string | undefined) => {
   const externalFragments: FragmentDefinitionNode[] = [];
   if (op) {
-    visit(parse(op), {
-      FragmentDefinition(def) {
-        externalFragments.push(def);
-      },
-    });
+    try {
+      visit(parse(op), {
+        FragmentDefinition(def) {
+          externalFragments.push(def);
+        },
+      });
+    } catch {
+      return [];
+    }
   }
   return externalFragments;
 };