move updateQueryStringURL to reducer

graphql · Jun 20, 2020 · c40b524 · c40b524
1 parent 83cb9d8
commit c40b524
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/packages/graphiql/src/api/providers/GraphiQLBrowserProvider.tsx b/packages/graphiql/src/api/providers/GraphiQLBrowserProvider.tsx
@@ -23,6 +23,7 @@ export const initialBrowserState: BrowserState = {
     variables: parseQueryStringURL(window.location.search).variables,
     operationName: parseQueryStringURL(window.location.search).operationName,
   },
+  queryStringParamsURL: '',
 };
 
 export const initialBrowserContextState: BrowserState & BrowserHandlers = {
@@ -47,6 +48,7 @@ const browserReducer: BrowserReducer = (state, action) => {
           ...state.queryStringParams,
           [parameter]: value,
         },
+        queryStringParamsURL: updateQueryStringURL(state.queryStringParams),
       };
     }
     default: {
@@ -72,8 +74,8 @@ export function BrowserProvider({ children }: BrowserProviderProps) {
   );
 
   React.useEffect(() => {
-    updateQueryStringURL(state.queryStringParams);
-  }, [state.queryStringParams]);
+    history.replaceState(null, document.title, state.queryStringParamsURL);
+  }, [state.queryStringParamsURL]);
 
   return (
     <BrowserContext.Provider

diff --git a/packages/graphiql/src/api/types.ts b/packages/graphiql/src/api/types.ts
@@ -33,4 +33,5 @@ export type SessionState = {
 
 export type BrowserState = {
   queryStringParams: any;
+  queryStringParamsURL: string;
 };
diff --git a/packages/graphiql/src/utility/updateQueryStringURL.ts b/packages/graphiql/src/utility/updateQueryStringURL.ts
@@ -25,6 +25,6 @@ export function updateQueryStringURL(parameters: any) {
           );
         })
         .join('&');
-    history.replaceState(null, document.title, newSearch);
+    return newSearch;
   }
 }