enable sonarjs/no-identical-functions, `sonarjs/no-unused-collectio…

…n`, `sonarjs/no-extra-arguments` rules (#3038)
graphql · Feb 24, 2023 · 708c428 · 708c428
1 parent 04c876b
commit 708c428
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 8 deletions.
diff --git a/.changeset/strong-tips-know.md b/.changeset/strong-tips-know.md
@@ -0,0 +1,5 @@
+---
+'vscode-graphql-execution': patch
+---
+
+remove unused collection `operationNames` in `executeOperation()`
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -111,6 +111,9 @@ module.exports = {
     'require-await': 0,
     'vars-on-top': 0,
     yoda: 1,
+    'sonarjs/no-identical-functions': 'error',
+    'sonarjs/no-unused-collection': 'error',
+    'sonarjs/no-extra-arguments': 'error',
 
     // Strict Mode (http://eslint.org/docs/rules/#strict-mode)
     strict: 0,

diff --git a/packages/graphiql-react/src/explorer/components/__tests__/doc-explorer.spec.tsx b/packages/graphiql-react/src/explorer/components/__tests__/doc-explorer.spec.tsx
@@ -178,6 +178,7 @@ describe('DocExplorer', () => {
     const { field } = (Query as GraphQLObjectType).getFields();
 
     // A hacky component to set the initial explorer nav stack
+    // eslint-disable-next-line sonarjs/no-identical-functions -- todo: could be refactored
     const SetInitialStack: React.FC = () => {
       const context = useContext(ExplorerContext)!;
       useEffect(() => {

diff --git a/packages/graphiql/__mocks__/@graphiql/react.tsx b/packages/graphiql/__mocks__/@graphiql/react.tsx
@@ -256,12 +256,11 @@ export const QueryEditor: typeof _QueryEditor = function QueryEditor(props) {
   return <div data-testid="query-editor" ref={ref} />;
 };
 
-export const ResponseEditor: typeof _ResponseEditor = function ResponseEditor(
-  props,
-) {
-  const ref = useResponseEditor(props);
-  return <div ref={ref} />;
-};
+export const ResponseEditor: typeof _ResponseEditor =
+  function ResponseEditor() {
+    const ref = useResponseEditor();
+    return <div ref={ref} />;
+  };
 
 export const VariableEditor: typeof _VariableEditor = function VariableEditor(
   props,

diff --git a/packages/graphql-language-service/src/interface/getDefinition.ts b/packages/graphql-language-service/src/interface/getDefinition.ts
@@ -184,6 +184,7 @@ function getDefinitionForNodeDefinition(
   };
 }
 
+// eslint-disable-next-line sonarjs/no-identical-functions
 function getDefinitionForFieldDefinition(
   path: Uri,
   text: string,

diff --git a/packages/vscode-graphql-execution/src/helpers/network.ts b/packages/vscode-graphql-execution/src/helpers/network.ts
@@ -34,6 +34,7 @@ export class NetworkHelper {
     this.outputChannel = outputChannel;
     this.sourceHelper = sourceHelper;
   }
+
   private buildClient({
     operation,
     endpoint,
@@ -112,12 +113,10 @@ export class NetworkHelper {
     projectConfig,
   }: ExecuteOperationOptions) {
     const operationTypes: OperationTypeNode[] = [];
-    const operationNames: string[] = [];
 
     visit(literal.ast, {
       OperationDefinition(node) {
         operationTypes.push(node.operation);
-        operationNames.push(node.name?.value || '');
       },
     });
     const fragmentDefinitions = await this.sourceHelper.getFragmentDefinitions(