This repository was archived by the owner on Mar 20, 2023. It is now read-only.
fix: failing tests on Node 12 #762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyarik
force-pushed
the
fix-failing-tests-on-node12
branch
from
0ca7458 to
de971ef
Compare
The issue of tests failing on Node v12 was caused by the `throw-deprecation: true` option specified in `.mocharc.yml`.
kyarik
force-pushed
the
fix-failing-tests-on-node12
branch
from
de971ef to
60328ff
Compare
|
@acao can we merge this asap? this will unblock dozen of PRs. |
|
@kyarik @junminstorage just seeing this now, on vacation my bad! yes merging now, thanks for this! |
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #756
The issue of tests failing on Node 12 was caused by the
throw-deprecation: trueoption specified in.mocharc.yml.CC: @acao @junminstorage