Skip to content
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

Extensions function receives raw query param #248

Closed
wants to merge 2 commits into from
Closed

Extensions function receives raw query param #248

wants to merge 2 commits into from

Conversation

eladitzhakian
Copy link

Following @nodkz 's suggestion here (and also, I really need this 😄 )

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@eladitzhakian eladitzhakian changed the title Extensions function received raw query param Extensions function receives raw query param Mar 14, 2017
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@asiandrummer
Copy link
Contributor

@eladitzhakian we should able to get the query string by printing the document AST (print(ast)) - would that suffice your use case?

@eladitzhakian
Copy link
Author

eladitzhakian commented Mar 17, 2017

@asiandrummer That might work, and it's not the only workaround as the query string is also available via the req variable, but I still believe it belongs in a dedicated arg. The raw query is commonly needed, no point digging through other objects to try and get it.

@leebyron
Copy link
Contributor

Hey @eladitzhakian, sorry for the wait. #302 now ensures that this value is available for all options including extensions - however you will need to refer to the value provided in the options function - does that work for you?

@eladitzhakian
Copy link
Author

@leebyron sure, thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants