Skip to content

Fragment spreads in Interface types #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dyedgreen
Copy link
Contributor

Closes #407

@dyedgreen
Copy link
Contributor Author

As a note: I'm not sure if there is a difference between the async and sync type resolution which I'm missing with this. The tests I added are async, so the fix might miss out on the sync case of this bug (if it exists).

@tyranron
Copy link
Member

tyranron commented Apr 2, 2021

@dyedgreen thanks for the contribution!

Actually, yes. The sync execution is implemented separately (it has similar name and flow). So, it would be nice to provide a fix for it too and cover it with tests.

@tyranron tyranron added the enhancement Improvement of existing features or bugfix label Apr 2, 2021
Copy link
Member

@LegNeato LegNeato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for the PR and including tests! 🍻

@LegNeato LegNeato merged commit e7f7e7b into graphql-rust:master Apr 2, 2021
@LegNeato
Copy link
Member

LegNeato commented Apr 4, 2021

This is now on crates.io. Thank you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic when using fragment of a implementation in a interface
3 participants