You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
At the moment, it's possible to deserialize GraphQLBatchRequest as an empty Vec<GraphQLRequest>. The downstream implementations (like juniper_warp) rely transparently on that, executing empty batch and returning empty response.
I'm unsure this is OK. Maybe, it's better to reject empty batches at deserialization level?
Describe the solution you'd like
The one was implemented once in early juniper_actix iterations:
Is your feature request related to a problem? Please describe.
At the moment, it's possible to deserialize
GraphQLBatchRequest
as an emptyVec<GraphQLRequest>
. The downstream implementations (likejuniper_warp
) rely transparently on that, executing empty batch and returning empty response.I'm unsure this is OK. Maybe, it's better to reject empty batches at deserialization level?
Describe the solution you'd like
The one was implemented once in early
juniper_actix
iterations:Describe alternatives you've considered
Leave it "as is". But seems to be more error-prone for frontends.
If it something desirable, I'll submit the PR shortly.
The text was updated successfully, but these errors were encountered: