Bring compatibility with Channels v3 #76
Conversation
fabienheureux
changed the title
I added a workflow/ci.yml file, but I don't understand why actions are not ran. |
|
Ha nevermind, they are ran on the fork https://github.com/fabienheureux/graphql-ws/actions |
|
@jkimbo tests are now running, and they pass 👍 https://github.com/fabienheureux/graphql-ws/runs/3380650273?check_suite_focus=true |
| django==2.*; python_version>="3" | ||
| channels==2.*; python_version>="3" | ||
| django==3.*; python_version>="3" | ||
| channels==3.*; python_version>="3" |
There was a problem hiding this comment.
Is it safe to assume all python >3 users will use django ?
There was a problem hiding this comment.
I meant "will use django 3"
| @@ -91,7 +91,7 @@ def test_observer_data(): | |||
| send_error=send_error, | |||
| send_message=send_message, | |||
| ) | |||
| observer.on_next('data') | |||
| observer.on_next("data") | |||
There was a problem hiding this comment.
I ran black on the repo locally to fix various code style issues
Channels v3 is currently not supported.
This bring changes from #74 alongside an import that does not work with channels because it was renamed in django/channels@4f32074#diff-8adaf2e6e01ec2cc05dd10bfd212d6dddfadabe0ddc679b821e03024806647b7
Also in this PR, I added github actions in order to have the tests running again on push/PR https://github.com/fabienheureux/graphql-ws/runs/3380650273?check_suite_focus=true