Support custom query parser in execute_graphql_request #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been checking per function performance on a project using Graphene, and it turns out the single biggest issue for simple queries is raw query parsing and subsequent conversion to AST.
The rationale for this PR is I've never seen anyone not at least caching queries at this step in production (some logging also usually happens here): enabling custom query parsing allows people to implement additional logic here without having to rewrite graphql-server-core (which they usually do for now).
A custom parsing step looks like this:
Some LRU cache or logging can now easily be added on top of this.
Please check the following commit to see how it would work in practice:
Hellzed/aiohttp-graphql@2abe5d1