Skip to content

Expose version number as __version__ #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 11, 2020
Merged

Expose version number as __version__ #50

merged 2 commits into from
Jul 11, 2020

Conversation

@KingDarBoja
Copy link
Contributor

@KingDarBoja KingDarBoja commented Jul 11, 2020

Fixes #47 based on graphql-core logic to handle package version.

@KingDarBoja KingDarBoja added the type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change label Jul 11, 2020
@KingDarBoja KingDarBoja requested review from Cito and jkimbo July 11, 2020 17:28
@KingDarBoja KingDarBoja self-assigned this Jul 11, 2020
jkimbo
jkimbo approved these changes Jul 11, 2020
View reviewed changes
Copy link
Member

@jkimbo jkimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@KingDarBoja KingDarBoja merged commit 351ca7a into graphql-python:master Jul 11, 2020
@KingDarBoja KingDarBoja deleted the expose-version-number branch July 11, 2020 19:39
@KingDarBoja KingDarBoja added this to the GraphQL-Server (V3) milestone Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkimbo jkimbo jkimbo approved these changes

@Cito Cito Awaiting requested review from Cito

Assignees

@KingDarBoja KingDarBoja

Labels

type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change

Projects

None yet

Milestone

GraphQL-Server (V3)

Development

Successfully merging this pull request may close these issues.

Expose version number as __version__

2 participants

@KingDarBoja @jkimbo