relay.NodeField does not propagate arguments to Field

[tdiam]

The current implementation of NodeField's constructor does not propagate name, deprecation_reason or **kwargs to its parent Field constructor.
This would be useful, for example, when the field has a name that is reserved in Python:

klass = Node.Field(name='class', ...)

Is this expected behavior or is a fix needed?

Test code

from graphene import Node, ObjectType, Schema, String

droids = {1: {'name': 'R2-D2'}}

class DroidNode(ObjectType):
    class Meta:
        interfaces = (Node,)

    name = String()

    @classmethod
    def get_node(cls, info, id):
        return DroidNode(**droids[id])

class Query(ObjectType):
    droid = Node.Field(DroidNode, name='robot')

schema = Schema(query=Query)


def test_field_name_is_robot():
    r = schema.execute(
        """
        {
            __type(name: "Query") {
                fields { name }
            }
        }
        """
    )
    assert r.data['__type']['fields'][0]['name'] == 'robot'

[chason]

I am currently running into this issue passing description to the constructor so that the automatically generated documentation in GraphiQL says something besides "The ID of the object".

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[mattaustin]

I don't believe this issue to be stale. I am encountering the same problem today, and it would be great to see the related pull request merged.