Convert Django form / DRF decimals to Graphene decimals

[ulgens]

Fixes #91

(Branch name is outdated. I can create a new PR if it's necessary.)

[zbyte64]

#91 is fixed, is this still relevant? What's this about test_should_query_filter_node_limit ?

[ulgens]

@zbyte64 I don't think this is still relevant, i'll test and update it asap. The issue with the test, as far as i remember, registering a decimal as string affected incoming data type in pagination, paginator was expecting a decimal value (not sure how and why).

[ulgens]

@zbyte64 This is still relevant. #1083 doesn't touch Django form based conversions at all. I'll try to make it work with that new graphene.Decimal type.

[ulgens]

@zbyte64 I couldn't understand why this change is necessary and i can use some help 🙂

The filter here uses NumberFilter from django-filters and it expects a decimal input. Decimal(1) == Decimal("1") is true but when that input is numeric 1, the test fails with

FAILED graphene_django/filter/tests/test_fields.py::test_should_query_filter_node_limit - assert not [GraphQLError('Argument "limit" has invalid value 1.\nExpected type "Decimal", found 1.')]

[zbyte64]

I experimented with adding the following above line 671:

assert Query.all_reporters.filtering_args["limit"].type is Decimal, str(
        Query.all_reporters.filtering_args["limit"].type
    )

Interestingly this line did not fail. So we know we're generating the right graphene type at least.

[zbyte64]

It is easier to get a stack trace with v3 than v2, still working on this :/

[zbyte64]

Something interesting happened when I branched and rebased off v3, that particular error went away but then it stopped applying the limit, filter_limit no longer gets called. BUT if I then switch the form conversion back to float the method gets called by django filter. Digging further the args being passed into DjangoFilterConnectoinField.resolve_queryset as limit as None when we convert to Decimal but not Float.

[zbyte64]

Traced the issue to graphene, I'll be sending them a PR in a moment

[zbyte64]

This should fix the issue we were seeing: graphql-python/graphene#1295

[jkimbo]

LGTM thanks @ulgens

(this should probably be part of the v3 release since it's a breaking change)

[ulgens]

@zbyte64 Why did we just merge it? 🙂 graphene didn't release a v2 version with decimal fix. I was intended to revert 1 -> "1" after that fix.