GraphQlView: Do not 'instantiate_middleware' if middleware is already a MiddlewareManager #952
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In graphq-core 2, the
MiddlewareManager
can have awrap_in_promise
boolean passed to activate/deactivate wrapping the middleware's result into a promise. This has a big performance impact on large requests.https://github.com/graphql-python/graphql-core-legacy/blob/52e030bbc6001fd378515600f81ccea0e360131b/graphql/execution/middleware.py#L25
The executor is instantiating the middleware as a
MiddlewareManager
if it's anything else than already aMiddlewareManager
:https://github.com/graphql-python/graphql-core-legacy/blob/52e030bbc6001fd378515600f81ccea0e360131b/graphql/execution/executor.py#L102
So in
graphene_django/views.py
by always converting middleware into a list, it breaks the ability to passe the argument to theMiddlewareManager
and always default towrap_in_promise=True
.This PR simply checks if the middleware is already a
MiddlewareManager
and pass it without pre-processing, allowing the end-user to define it themselves.