Skip to content

Pin an explicit version of django-filter (<2) on cookbook example #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2018

Conversation

NoumirPoutipou
Copy link
Contributor

With requirements set with django-filter==0.11.0, the cookbook example is unable to execute query using filters. Leading to a TypeError :

__init__() got an unexpected keyword argument 'request'

Due to line 95 in filter/fields.py

Pin it to the same requirements as graphene-django itself.

@coveralls
Copy link

coveralls commented Jul 24, 2018

Coverage Status

Coverage increased (+0.2%) to 94.667% when pulling a57098b on NoumirPoutipou:master into dc561c6 on graphql-python:master.

@syrusakbary syrusakbary merged commit 52d14f3 into graphql-python:master Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants