Skip to content

Road to 2.0 #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 27, 2017
Merged

Road to 2.0 #229

merged 11 commits into from
Aug 27, 2017

Conversation

syrusakbary
Copy link
Member

@syrusakbary syrusakbary commented Jul 25, 2017

This PR improves the codebase based on the next version of Graphene, 2.0.

Related PR: graphql-python/graphene#500

@coveralls
Copy link

coveralls commented Jul 25, 2017

Coverage Status

Coverage increased (+0.2%) to 92.581% when pulling 72529b7 on 2.0 into cec1a84 on master.

@coveralls
Copy link

coveralls commented Jul 25, 2017

Coverage Status

Coverage increased (+0.2%) to 92.581% when pulling f5ecee3 on 2.0 into cec1a84 on master.

@patrick91
Copy link
Member

Looks good :) Did you also get rid of the SeralizerInput field? so now all the fields inside the Serializer mutation are not wrapped?

@syrusakbary
Copy link
Member Author

@patrick91 will put it back soon! :)

@patrick91
Copy link
Member

@syrusakbary not sure I want that :) having SeralizerInput sounds a bit verbose, don't you think?

@graphql-python graphql-python deleted a comment from coveralls Aug 1, 2017
@graphql-python graphql-python deleted a comment from coveralls Aug 1, 2017
@graphql-python graphql-python deleted a comment from coveralls Aug 1, 2017
@graphql-python graphql-python deleted a comment from coveralls Aug 1, 2017
@graphql-python graphql-python deleted a comment from coveralls Aug 1, 2017
@graphql-python graphql-python deleted a comment from coveralls Aug 1, 2017
@graphql-python graphql-python deleted a comment from coveralls Aug 1, 2017
@graphql-python graphql-python deleted a comment from coveralls Aug 1, 2017
@graphql-python graphql-python deleted a comment from coveralls Aug 1, 2017
@graphql-python graphql-python deleted a comment from coveralls Aug 1, 2017
@coveralls
Copy link

coveralls commented Aug 1, 2017

Coverage Status

Coverage increased (+0.2%) to 92.581% when pulling 872ce39 on 2.0 into cec1a84 on master.

@syrusakbary syrusakbary merged commit 1bea96b into master Aug 27, 2017
@clodal clodal mentioned this pull request Sep 1, 2017
@syrusakbary syrusakbary deleted the 2.0 branch September 1, 2017 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants