-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Python 3.7 (EOL since EOL since 2023-06-27) from CI #1440
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, LGTM!
One comment: we may want to change the pre-commit
pyupgrade arg to use --py38-plus
now instead of py37:
graphene-django/.pre-commit-config.yaml
Line 22 in 8540a93
args: [--py37-plus] |
That could presumably be a separate PR after this, since we'll likely want to re-run it on all existing files to upgrade any syntax that was kept around in support of 3.7.
Good catch! We could also take this opportunity to switch to ruff? Ruff implements both |
Yeah great suggestion. I'm using ruff instead of pyupgrade, flake8, etc in a project of mine, and I'm a big fan! |
@sjdemartini I just include the change to |
…ython#1440) * Remove Python 3.7 (EOL since EOL since 2023-06-27) from CI * Remove unused context * Use pyupgrade --py38-plus in pre-commit
…ython#1440) * Remove Python 3.7 (EOL since EOL since 2023-06-27) from CI * Remove unused context * Use pyupgrade --py38-plus in pre-commit
https://devguide.python.org/versions/