Fix subscriptions in JS #1124
Merged
Fix subscriptions in JS #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing tests fail locally even without my change... |
|
Main branch should be fixed now. Please git fetch main, merge, and push to see if it resolves the build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "play" button on the graphiql web page does not work as expected with subscription.
With the following fix, when launching a subscription the "play" button changes to a "stop" button, allowing to stop subscriptions properly.
See the following video capture which shows how the fix works:
https://youtu.be/2Aks6wnYeRc
Fixes #1125