Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GraphiQL cleanup #1002

Merged
merged 4 commits into from
Jul 12, 2020
Merged

GraphiQL cleanup #1002

merged 4 commits into from
Jul 12, 2020

Conversation

eabruzzese
Copy link
Collaborator

I went back through my GraphiQL upgrade changes and cleaned up a bit:

  • Upgrade the window.fetch polyfill to the latest version.
  • Add subresource integrity (SRI) hashes for all CDN-loaded assets.
  • Run the graphiql.js file through prettier (using prettier's default settings).
  • Fix an issue where the SUBSCRIPTION_PATH value wasn't making it all the way to the view.

mvanlonden
mvanlonden approved these changes Jul 12, 2020
View reviewed changes
Copy link
Member

@mvanlonden mvanlonden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks Eric

@mvanlonden mvanlonden merged commit 057b491 into graphql-python:master Jul 12, 2020
@eabruzzese eabruzzese deleted the graphiql-cleanup branch July 12, 2020 19:52
@jkimbo
Copy link
Member

jkimbo commented Jul 13, 2020

Yes thanks @eabruzzese !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvanlonden mvanlonden mvanlonden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eabruzzese @jkimbo @mvanlonden