Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start warning if fields or exclude are not defined on DjangoObjectType #710

Closed
jkimbo opened this issue Jul 12, 2019 · 6 comments · Fixed by #981
Closed

Start warning if fields or exclude are not defined on DjangoObjectType #710

jkimbo opened this issue Jul 12, 2019 · 6 comments · Fixed by #981

Comments

@jkimbo
Copy link
Member

jkimbo commented Jul 12, 2019

So that model fields aren't accidentally exposed through DjangoObjectType I propose that we start warning if either fields or exclude aren't defined with the intention to error completely in the future. This would also align the API more with Django Rest Framework which hopefully makes it more familiar to most developers.

@stale
Copy link

stale bot commented Sep 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 10, 2019
@stale stale bot closed this as completed Sep 17, 2019
@jkimbo jkimbo reopened this Dec 26, 2019
@stale stale bot removed the wontfix label Dec 26, 2019
@stale stale bot added the wontfix label Apr 25, 2020
@graphql-python graphql-python deleted a comment from stale bot Apr 25, 2020
@radekwlsk
Copy link
Contributor

radekwlsk commented Jun 5, 2020

@jkimbo is anyone working on it? If not I would be happy to help and prepare PR for this issue.

@dopeboy is assigned but for almost a year now.

@jkimbo
Copy link
Member Author

jkimbo commented Jun 6, 2020

@radekwlsk if you have the time that would be great! I don't think anyone is working on it at the moment.

@radekwlsk
Copy link
Contributor

@radekwlsk if you have the time that would be great! I don't think anyone is working on it at the moment.

Great. I will start working on it tomorrow. You can assign me to the issue, @jkimbo .

@radekwlsk
Copy link
Contributor

@jkimbo You can close this.

@jkimbo jkimbo closed this as completed Jul 1, 2020
@jkimbo
Copy link
Member Author

jkimbo commented Jul 1, 2020

Thanks @radekwlsk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants