Skip to content

Commit

Permalink
Improv/documentation fixes (#895)
Browse files Browse the repository at this point in the history
* Bump up the minimum support Django version.

* Update documentation to mention support for Django 1.11.

Co-authored-by: Akhil <akhil@healthifyme.com>
  • Loading branch information
rip-the-jacker and hme-akhil committed Mar 7, 2020
1 parent aeb04d5 commit 1335221
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 4 deletions.
2 changes: 1 addition & 1 deletion docs/authorization.rst
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ To restrict users from accessing the GraphQL API page the standard Django LoginR
After this, you can use the new ``PrivateGraphQLView`` in the project's URL Configuration file ``url.py``:

For Django 1.9 and below:
For Django 1.11:

.. code:: python
Expand Down
16 changes: 15 additions & 1 deletion docs/installation.rst
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Requirements

Graphene-Django currently supports the following versions of Django:

* Django 2.X
* >= Django 1.11

Installation
------------
Expand All @@ -32,6 +32,20 @@ Add ``graphene_django`` to the ``INSTALLED_APPS`` in the ``settings.py`` file of
We need to add a ``graphql`` URL to the ``urls.py`` of your Django project:

For Django 1.11:

.. code:: python
from django.conf.urls import url
from graphene_django.views import GraphQLView
urlpatterns = [
# ...
url(r"graphql", GraphQLView.as_view(graphiql=True)),
]
For Django 2.0 and above:

.. code:: python
from django.urls import path
Expand Down
2 changes: 1 addition & 1 deletion docs/tutorial-plain.rst
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ from the command line.
$ python ./manage.py runserver
Performing system checks...
Django version 1.9, using settings 'cookbook.settings'
Django version 1.11, using settings 'cookbook.settings'
Starting development server at http://127.0.0.1:8000/
Quit the server with CONTROL-C.
Expand Down
2 changes: 1 addition & 1 deletion docs/tutorial-relay.rst
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ from the command line.
$ python ./manage.py runserver
Performing system checks...
Django version 1.9, using settings 'cookbook.settings'
Django version 1.11, using settings 'cookbook.settings'
Starting development server at http://127.0.0.1:8000/
Quit the server with CONTROL-C.
Expand Down

0 comments on commit 1335221

Please sign in to comment.