Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature add connect to requests transport #87

Conversation

leszekhanusz
Copy link
Collaborator

Refactor client and requests transport

  • Adding a connect function to establish the session
  • Using TransportError exceptions to be coherent with other transports
  • Adding tests for the requests transport using aiohttp as the server

Adding a connect function to establish the session
Using TransportError exceptions to be coherent with other transports
Adding tests for the requests transport using aiohttp as the server
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 99.206% when pulling d7d2e75 on leszekhanusz:feature_add_connect_to_requests_transport into 1948be5 on graphql-python:master.

@Cito Cito merged commit 70e54a4 into graphql-python:master May 16, 2020
@leszekhanusz leszekhanusz deleted the feature_add_connect_to_requests_transport branch May 17, 2020 05:19
@KingDarBoja KingDarBoja added this to the Version 3.0 milestone Jun 14, 2020
@KingDarBoja KingDarBoja added type: feature A new feature type: optimization A code change that improves performance type: tests Adding missing or correcting existing tests labels Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature A new feature type: optimization A code change that improves performance type: tests Adding missing or correcting existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants