-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to pass arguments to websockets.connect + some ssl tests + some cleaning #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Necessitate Python 3.6 Allows a connection to an Apollo GraphQL websocket endpoint Supports fetching schema from transport using the introspection query Supports queries, mutations AND subscriptions Supports connection using a client ssl certificate Only one request per connection for now
It is now possible to execute multiple queries in parallel using the same websocket connection
…om the command line
Adding fixtures to create a websocket server for the tests Allow ssl=False argument in transport
Adding exceptions: - TransportProtocolError - TransportQueryError - TransportServerError - TransportClosed Now 100% code coverage for transport/websockets.py Improvement of 'server' test fixture to simplify tests (list only answers)
Added _wait_closed event and wait_close coroutine to wait for the close task to finish Add exception 'TransportAlreadyConnected' used when trying to connect to an already connected transport Added new tests to test multiple connections in series or in parallel Refactor: - rename _close to _fail - rename _answer_loop to _receive_data_loop - rename listen_loop to receive_data_task
Testing validation using schema, type_def or introspection Fixing some flake8/black styling issues in tests_py36
From this commit of pytest-asyncio: pytest-dev/pytest-asyncio@a9e2213 The asyncio tests were not working anymore This is a bug of pytest-asyncio: pytest-dev/pytest-asyncio#157 As a workaround, adding event_loop parameter to all asyncio tests
…cify init payload + tests and documentation + black for style in tests_py36 folder
Adding tests to have 100% async client coverage without online tests
This allows us to keep the execute method sync in the AsyncClient class Rename client to session in all tests It is now possible to execute GraphQL queries synchronously on asynchronous transports Returning ExecutionResult.data instead of ExecutionResult in AsyncClient (This corresponds to the previous usage of the library)
Removing pytest_aiohttp dependency (copy only the fixture we need)
Fixing import order with isort Modify isort config to be compatible with black Now isort will fail if invalid import order is found isort upgraded to version 4.2.8 to fix bug PyCQA/isort#537 Fix posargs in tox.ini to allow to run tox for specific tests
Add -s to pytest to have better logs in tox Add -vb (verbose) to isort to have better logs in tox
For some reason on pypy3 with the version on travis (3.6.1), it takes 10 seconds to leave the async generator... So we increase the default timeout for a sync execute
Add execute_timeout to AsyncClient Add connect_timeout, ack_timeout and close_timeout to websockets transport Fix asyncio bugs of pypy3 v3.6.1 by adding await generator.aclose() in async for
Now flake8 also verify the tests_py36 folder
websockets: ssl argument is guessed from url if not provided Adding websockets ssl test with self signed certificate Using the self cert from websockets tests
Now using named dicts instead of kwargs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.