Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding node_tree method in utilities to debug and compare DocumentNode instances #449

Conversation

leszekhanusz
Copy link
Collaborator

The node_tree method allows to see the hierarchy of a DocumentNode object.

Now the DSL code will not set variable definitions for Fragments by default to be coherent with the default graphql-core parsing in the gql method.

Copy link

codecov bot commented Nov 19, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3a48a2f) 100.00% compared to head (9d068ad) 99.96%.

❗ Current head 9d068ad differs from pull request most recent head 2b56070. Consider uploading reports for the commit 2b56070 to get more accurate results

Files Patch % Lines
gql/dsl.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##            master     #449      +/-   ##
===========================================
- Coverage   100.00%   99.96%   -0.04%     
===========================================
  Files           28       29       +1     
  Lines         2579     2617      +38     
===========================================
+ Hits          2579     2616      +37     
- Misses           0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leszekhanusz
Copy link
Collaborator Author

@Cito I don't know if you have something similar for graphql-core but I think the node_tree method could be useful to you too to debug deep DocumentNode objects.

@leszekhanusz leszekhanusz merged commit a2f327f into graphql-python:master Nov 21, 2023
14 checks passed
@leszekhanusz leszekhanusz deleted the chore_dsl_debug_document_method branch November 21, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant