Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix subscribe breaking change in graphql-core 3.3.0a3 #417

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Fix subscribe breaking change in graphql-core 3.3.0a3 #417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gql/transport/local_schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ async def subscribe(
The results are sent as an ExecutionResult object
"""

subscribe_result = await subscribe(self.schema, document, *args, **kwargs)
subscribe_result = subscribe(self.schema, document, *args, **kwargs)

if isinstance(subscribe_result, ExecutionResult):
yield subscribe_result
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from setuptools import setup, find_packages

install_requires = [
"graphql-core>=3.3.0a2,<3.4",
"graphql-core>=3.3.0a3,<3.4",
"yarl>=1.6,<2.0",
"backoff>=1.11.1,<3.0",
]
Expand Down
2 changes: 1 addition & 1 deletion tests/starwars/test_subscription.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ async def test_subscription_support():
params = {"ep": "JEDI"}
expected = [{**review, "episode": "JEDI"} for review in reviews[6]]

ai = await subscribe(StarWarsSchema, subs, variable_values=params)
ai = subscribe(StarWarsSchema, subs, variable_values=params)

result = [result.data["reviewAdded"] async for result in ai]

Expand Down