Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSLSchema transform type attribute assert into AttributeError #409

Merged

Conversation

leszekhanusz
Copy link
Collaborator

Better error for DSLSchema invalid attributes.
Changing an assert into an AttributeError.

See PR #406

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8e1c6f1) 100.00% compared to head (c6d0297) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #409   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines         2384      2385    +1     
=========================================
+ Hits          2384      2385    +1     
Impacted Files Coverage Δ
gql/dsl.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@leszekhanusz leszekhanusz merged commit f3b0f26 into graphql-python:master Apr 27, 2023
@leszekhanusz leszekhanusz deleted the fix_dsl_assert_schema_type branch April 27, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant