-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] httpx async transport #340
[DRAFT] httpx async transport #340
Conversation
Yes, Thanks for looking into this!
Maybe? But if we only support AsyncClient at first it's great too.
No, only the first option is possible, the gql client should have the power to connect and close the connection itself. It is necessary for example for the permanent reconnecting session feature. What you can (and should) do is to add a
No, It's ok if the tests are copy-pasted to be simpler and closer to reality. DRY is not required for tests IMHO. |
Some tips for the CI:
|
I'll get back to this in the next couple weeks. Got a bit sidetracked with syntax highlighting over in graphiql. Thanks for the clarification, glad I didn't get any further with implementation before asking |
@qw-in I'd love to help out and get this off and running (just making some adjustments so CI passes). I have a project that'd benefit from an |
@jpavlav absolutely, feel free to take over the branch! Not sure if you'll be able to directly since it's a fork but I'll happily close this pr in favour of yours. Thanks! |
Hi, I need this for work and found it easier to contribute an alternative PR: |
Fix #154
Hello, not sure if there is still interest in supporting an httpx transport out of the box. I would be happy to maintain a separate package if that is preferable. Either way, thanks for having a look!
I've really just implemented the bare minimum so far:
aiohttp
aiohttp
- skipping the ones not yet relevantWould love some guidance on a few things:
httpx.Client
andhttpx.AsyncClient
?cookies
) to the transport vs passing in an instance ofAsyncClient
. Leaning towards the second option. If a client is passed in, transport is not responsible for closing it. A usage example:aiohttp
tests forhttpx
rather than duplicate?