Skip to content

PhoenixChannelWebsocketsTransport inherits WebsocketsTransportBase #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

leszekhanusz
Copy link
Collaborator

Refactor to remove attributes not related to the transport

@codecov-commenter
Copy link

Codecov Report

Merging #280 (0a400dd) into master (e2d2085) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #280   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines         1997      2001    +4     
=========================================
+ Hits          1997      2001    +4     
Impacted Files Coverage Δ
gql/transport/phoenix_channel_websockets.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2d2085...0a400dd. Read the comment docs.

@leszekhanusz leszekhanusz changed the title PhoenixChannelWebsocketsTransport inherits WebsocketsBase PhoenixChannelWebsocketsTransport inherits WebsocketsTransportBase Dec 10, 2021
@leszekhanusz leszekhanusz merged commit ec37cb0 into graphql-python:master Dec 10, 2021
@leszekhanusz leszekhanusz deleted the fix_phoenix_inherits_websockets_base branch March 12, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants