Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set use_json default true in RequestsHTTPTransport #16

Merged
merged 1 commit into from
May 15, 2020
Merged

set use_json default true in RequestsHTTPTransport #16

merged 1 commit into from
May 15, 2020

Conversation

stegben
Copy link
Contributor

@stegben stegben commented May 12, 2017

Since we usually set content-type: application/json when we use graphql ?

@ahussain3
Copy link

+1

@coveralls
Copy link

coveralls commented May 15, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-98.8%) to 0.0% when pulling 1074bdf on stegben:patch-1 into e98ff27 on graphql-python:master.

@stegben stegben force-pushed the patch-1 branch 5 times, most recently from f77809e to 42c8816 Compare May 15, 2020 09:58
@Cito
Copy link
Member

Cito commented May 15, 2020

I think this makes sense. Quoting the docs: A standard GraphQL POST request should use the application/json content type, and include a JSON-encoded body.

@Cito Cito merged commit 9f6e4e1 into graphql-python:master May 15, 2020
Cito added a commit that referenced this pull request May 15, 2020
@Cito
Fix tests after default for use_json changed in #16
481b837
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stegben @ahussain3 @coveralls @Cito