Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raises KeyError when argument is invalid. #121

Merged
merged 4 commits into from
Jul 31, 2020
Merged

Raises KeyError when argument is invalid. #121

merged 4 commits into from
Jul 31, 2020

Conversation

JBrVJxsc
Copy link
Contributor

@JBrVJxsc JBrVJxsc commented Jul 25, 2020

Previously an invalid argument will cause AttributeError.

File "/venv/lib/python3.7/site-packages/gql/dsl.py", line 94, in args arg_type_serializer = get_arg_serializer(arg.type) AttributeError: 'NoneType' object has no attribute 'type'

This pull request will make the error message more meaningful.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e58b08e on JBrVJxsc:master into 8fc378d on graphql-python:master.

@KingDarBoja KingDarBoja added the type: bug An issue or pull request relating to a bug label Jul 31, 2020
@KingDarBoja KingDarBoja self-requested a review July 31, 2020 00:43
@KingDarBoja KingDarBoja merged commit ba18b5e into graphql-python:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug An issue or pull request relating to a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants