Parsing incorrectly wipes out mapping

[pvanderlinden]

Describe the bug
The parsing logic completely wipes out parent value, if one of the fields in null.

e.g. the value is a list with a type in it with the following definition (removed all the other fields for simplicity)

  node {
    ...other fields
    from {
      address
    }
    to {
      address
    }
  }
}

if I get the following result:

[
{'node': {'from': {'address': '0x45b9ad45995577fe'}, 'to': {'address': '0x6394e988297f5ed2'}}},
{'node': {'from': None, 'to': {'address': '0x6394e988297f5ed2'}}},
]

the parsed result will end up being:

[
{'node': {'from': {'address': '0x45b9ad45995577fe'}, 'to': {'address': '0x6394e988297f5ed2'}}},
None
]

Expected behavior
Result should be:

[
{'node': {'from': {'address': '0x45b9ad45995577fe'}, 'to': {'address': '0x6394e988297f5ed2'}}},
{'node': {'from': None, 'to': {'address': '0x6394e988297f5ed2'}}},
]

System info (please complete the following information):

• OS: Linux
• Python version: 3.10
• gql version: 3.2.0
• graphql-core version: 3.2.1

[leszekhanusz]

It is not clear what you mean by "parsing logic".

Please help me to reproduce your problem:

• which code did you use (sync or async, which transport, which arguments, ...) Please post your full code.
• what is the backend?
• please provide a schema and a full valid query and the expected response.

[leszekhanusz]

Please also activate debug logs and post the result here.

[pvanderlinden]

I'm currently trying to write a test to demonstrate the issue.

I don't know how much of the details as I can share as this is an alpha version of a backend I have access to with authentication. I don't think the backend matters in anyway to be honest. This is purely when parsing the results (execute(parse_results=True). I have the debug logs, but again, not entirely sure what information I can post (and it will be a ton of logs).

[leszekhanusz]

ok, if you could make a failing test and add it as a PR that would be nice.

[pvanderlinden]

@leszekhanusz

I created the failing test (without parse_results=True the test will pass). Is this clarifying the bug?

[pvanderlinden]

This might be a bug in graphql-core, but I was unable to track down the cause of the bug so far.

[Cito]

@pvanderlinden @leszekhanusz The problem seems to be somewhere in the parse_result_recursive function of gql (the ParseResultVisitor), not graphql-core.

[leszekhanusz]

Yes, it's possible I found the problem. I'll make more tests tomorrow and get the PR cleaned, I don't really remember why there was a special case for None here.

[pvanderlinden]

Thanks. I will test run the branch tomorrow on my code

[leszekhanusz]

At least now I know there is at least one person using this feature 😄

[pvanderlinden]

At least now I know there is at least one person using this feature 😄

Haha, always good to know. I'm using it to automatically convert 2 custom scalars: a datetime like type and a decimal (fixed point).

[leszekhanusz]

Fixed in v3.3.0