Merged
Conversation
bbakerman
approved these changes
Oct 2, 2020
Member
bbakerman
left a comment
There was a problem hiding this comment.
Thanks for this. This is an excellent work around until we can fix upstream.
Member
|
Can I ask that a similar PR get created that targets graphql-java-14-stable branch. Perhaps @setchy you may be able to help here |
setchy
pushed a commit
to setchy/graphql-java-extended-validation
that referenced
this pull request
Oct 2, 2020
(cherry picked from commit d70dbe6)
setchy
added a commit
that referenced
this pull request
Oct 2, 2020
…va-14-stable fix schema wiring (#30)
Collaborator
|
Sorted - see #33 |
Member
|
This is not quite fixed with the PR - that is now if you have self referencing types there is a StackOverflow eg this one. DirectivesAndTypeWalker will stack overflow with such a type because it walks naively |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #17
As a temporary fix, at least until it is possible to have fields resolved correctly in
onFieldofValidationSchemaWiring.This has the downside to only validate the fields directive parameters on the first call to the graphQL API, which is another problem, because the API will start normally and throw an exception on the first call. It's yours to decide if it's better to fail validation at start, but fail to validate half the queries, or throw an exception on the first call...