Feature/graphql annotations sample #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlasiusSecundus
force-pushed
the
feature/graphql-annotations-sample
branch
3 times, most recently
from
b3dc774 to
d7464f4
Compare
Using annotations instead of marker interfaces for query, mutation, subscription resolvers.
BlasiusSecundus
force-pushed
the
feature/graphql-annotations-sample
branch
from
d7464f4 to
37a6179
Compare
BlasiusSecundus
force-pushed
the
feature/graphql-annotations-sample
branch
from
95bb6d7 to
9930751
Compare
|
Is it still a draft or ready to be merged? |
|
I'll plan to update the tests to use the newly added fluent assertion API. Now that the main blocker is fixed, I think I can finalize the PR this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example project for graphql-annotations feature. It is still a draft, because it has a strange issue - CI test run on MacOS Java 11 and Ubuntu - Java 11 fail because the fields of the CreatePerson parameter are null in the createPerson muations. I could not reproduce the issue on my Ubuntu machine. (Tests run fine and app also works)