Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented May 3, 2022

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.graphql-java:graphql-java 18.0 -> 18.1 age adoption passing confidence

Release Notes

graphql-java/graphql-java

v18.1

This bug fix release contains an important fix

https://github.com/graphql-java/graphql-java/pull/2773

The latest 18.0 version of graphql-java changed the way raw values are resolved to canonical values.

However this revealed a bug in MaxQueryXXX instrumentation where invalid values (null being present for non nullable input values) caused an exception rather than generating a graphql error. This is not a behavior we intended.

The bug is only present if you use graphql.analysis.MaxQueryDepthInstrumentation and graphql.analysis.MaxQueryDepthInstrumentation

What's Changed

New Contributors

Full Changelog: graphql-java/graphql-java@v18.0...v18.1


Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label May 3, 2022
@renovate renovate bot force-pushed the renovate/graphql-java-(ignoring-snapshot-builds) branch from bc07ceb to 93a5d0c Compare May 14, 2022 21:04
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@cmuchinsky
Copy link

With spring-boot-dependencies version 2.7.0 including GraphQL 18.1 and the GA of spring-graphql version 1.0.0 supporting GraphQL 18+, it would be great if this PR could be merged and a new version of graphql-java-servlet released so all 3 can be used together.

@oliemansm
Copy link
Member

@cmuchinsky When using spring-graphql you don't need graphql-java-servlet, since that library doesn't rely on this one at all, but on graphql-java directly. The spring-graphql project is an alternative to the graphql-java-kickstart project.

@oliemansm oliemansm added this to the 13.0.0 milestone May 25, 2022
@oliemansm oliemansm merged commit fefcf80 into master May 25, 2022
@renovate renovate bot deleted the renovate/graphql-java-(ignoring-snapshot-builds) branch May 25, 2022 06:31
@cmuchinsky
Copy link

@cmuchinsky When using spring-graphql you don't need graphql-java-servlet, since that library doesn't rely on this one at all, but on graphql-java directly. The spring-graphql project is an alternative to the graphql-java-kickstart project.

Thanks @oliemansm, we are planning to switch to spring-graphql in the future, but we aren't there yet. For now we simply rely on the spring-boot-dependencies BOM to align our dependencies. Ideally we want to upgrade to GraphQL 18.1 and then perform the switch from graphql-java-servlet over to spring-graphql afterwards. Anyhow, thanks for the tip and appreciate the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants