Skip to content

Add listener for errors that occur in parsing InvocationInput #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 21, 2022
Merged

Add listener for errors that occur in parsing InvocationInput #439

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e1a5734
Add test
heowc Feb 22, 2022
21f96a8
Add test
heowc Feb 22, 2022
91933d5
Merge remote-tracking branch 'origin/gh-417' into gh-417
heowc May 2, 2022
065ee30
Add listener for errors that occur in parsing `InvocationInput`
heowc May 2, 2022
14077de
Remove unused import
May 3, 2022
2a5fe3f
Indent
heowc May 25, 2022
99ba5e7
Indent
heowc May 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add test
  • Loading branch information
@heowc
heowc committed Feb 22, 2022
commit e1a5734353ef2fbd342da972e5cbfaf98c27c094
16 changes: 16 additions & 0 deletions ...a-servlet/src/test/groovy/graphql/kickstart/servlet/AbstractGraphQLHttpServletSpec.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -755,6 +755,22 @@ b
getResponseContent().data.echoFiles == ["test", "test again"]
}

def "errors while accessing file from the request"() {
setup:
request = Spy(MockHttpServletRequest)
request.setMethod("POST")
request.setContentType("multipart/form-data, boundary=test")
// See https://github.com/apache/tomcat/blob/main/java/org/apache/catalina/connector/Request.java#L2775...L2791
request.getParts() >> { throw new IllegalStateException() }

when:
servlet.doPost(request, response)

then:
response.getStatus() == STATUS_ERROR
response.getContentLength() == 0
}

def "batched query over HTTP POST body returns data"() {
setup:
request.setContent('[{ "query": "query { echo(arg:\\"test\\") }" }, { "query": "query { echo(arg:\\"test\\") }" }]'.bytes)
Expand Down