Serialize query response directly to Servlet's output stream to avoid intermediate String object creation #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… intermediate String object creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I checked this improvement using this test
customersquery shailender-bathula/samples@fd1bf6d and bombardier HTTP benchmarking tool.I ran the application using the default settings i.e.
../gradlew appRunand benchmarking like this:bombardier --method POST --header "Content-Type: application/json" --duration=70s --connections=110 --body '{ "query": "{ customers {id firstName lastName yearOfBirth email} }" }' http://localhost:8080/servlet-hello-world/graphqlThere was an improvement of 5 - 10 requests/second before and after in those tests. The difference may be more in higher throughput environments.