Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to make ApolloSubscriptionProtocolHandler more pluggable #197

Closed
verunder opened this issue Jul 16, 2019 · 2 comments
Closed
Milestone

Comments

@verunder
Copy link

This is clearly enhancement/extension request.

Here is the situation description:
Basically, we use different server instead of spring-boot library. Vert.X to be specific.
While ApolloSubscriptionProtocolHandler class is awesome and has all the functionality that I need, it is based off different classes that I have the handle to with Vert.X. (Vert.x web-socket does not implement javax.websocket.Session).

I was wondering if you are open to the possibility of refactoring the ApolloSubscriptionProtocolHandler into something that is more pluggable and does not depend on the javax.websocket.Session(at minimum)? I can help, if necessary.

Sorry if I stepped over the line with this request. :)

@oliemansm
Copy link
Member

Definitely open to that. Not sure when I'll be able to work on that, so contributions are welcome too!

@oliemansm oliemansm added this to the 9.0.0 milestone Nov 24, 2019
@oliemansm
Copy link
Member

This will be released in 9.0.0, see #217.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants