Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is @defer already supported? #133

Closed
ahhhkah opened this issue Nov 28, 2018 · 3 comments
Closed

Is @defer already supported? #133

ahhhkah opened this issue Nov 28, 2018 · 3 comments
Milestone

Comments

@ahhhkah
Copy link

ahhhkah commented Nov 28, 2018

Hi,

is the @defer-Directive already supported by the servlet? (https://www.graphql-java.com/documentation/v11/defer/)
Any plans on implementing it in the near future?

Thank you in advance,
ahhhkah

@oliemansm
Copy link
Member

@ahhhkah This project simply wraps graphql-java, so would expect most if not all to just work. Have you tried it?

@ahhhkah
Copy link
Author

ahhhkah commented Nov 28, 2018

Yes, we tried a requests with @defer on our API, but the "deferredResults" in the extensions was empty. I think the AbstractGraphQLHttpServlet.java has to be changed quite a bit to support it.

If we find the time to implement a solution, we will create a pull request. If you start working on it (or have an idea what has to be done), let us know.

@oliemansm
Copy link
Member

Ok, haven't looked at that defer stuff yet. Please note that there's a branch splitting up this project in two modules, so if you want to start work on this make sure to base it on that one. Seeing you mention it needs quite some changes it would otherwise become a nightmare to merge.

@oliemansm oliemansm added this to the 8.1.0 milestone Nov 16, 2019
@oliemansm oliemansm modified the milestones: 8.1.0, 9.0.0 Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants