-
Couldn't load subscription status.
- Fork 3
Enhance CI benchmarks with regression detection #531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🐋 This PR was built and pushed to the following Docker images: Image Names: Platforms: Image Tags: Docker metadata{
"buildx.build.ref": "builder-a45b52bd-33cb-4549-99e9-7def76a6d499/builder-a45b52bd-33cb-4549-99e9-7def76a6d4990/97w5vilsbswt2552d4mps7185",
"containerimage.descriptor": {
"mediaType": "application/vnd.oci.image.index.v1+json",
"digest": "sha256:a7b181d78ec616d8c5279c1916fc135fdf3f6394b1b1b5a8d4d0b2fa5adf7f60",
"size": 1609
},
"containerimage.digest": "sha256:a7b181d78ec616d8c5279c1916fc135fdf3f6394b1b1b5a8d4d0b2fa5adf7f60",
"image.name": "ghcr.io/graphql-hive/router:pr-531,ghcr.io/graphql-hive/router:sha-52abb5a"
} |
✅
|
This commit introduces a new script to detect performance regressions. It compares the 'http_reqs' rate metric from the PR summary against the main branch summary and determines if there is a regression of more than 5%. Also, the commit adds .gitignore entries, a script to detect regressions, and changes to the CI workflow to execute the benchmarks and compare the results.
d1333c1 to
4d9015d
Compare
| if: github.event_name == 'pull_request' | ||
| uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5 | ||
| with: | ||
| ref: main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we do not chain PR a lot, but this should really be ${{ github.base_ref }}
This commit introduces a new script to detect performance regressions. It compares the 'http_reqs' rate metric from the PR summary against the main branch summary and determines if there is a regression of more than 2%.
Also, the commit adds .gitignore entries, a script to detect regressions, and changes to the CI workflow to execute the benchmarks and compare the results.