Skip to content

Conversation

@theguild-bot
Copy link
Collaborator

@theguild-bot theguild-bot commented Oct 27, 2025

🤖 New release

  • hive-router-plan-executor: 6.0.0 -> 7.0.0 (⚠ API breaking changes)
  • hive-router: 0.0.15 -> 0.0.16 (✓ API compatible changes)

hive-router-plan-executor breaking changes

--- failure type_mismatched_generic_lifetimes: type now takes a different number of generic lifetimes ---

Description:
A type now takes a different number of generic lifetime parameters. Uses of this type that name the previous number of parameters will be broken.
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.43.0/src/lints/type_mismatched_generic_lifetimes.ron
Failed in:
  Struct ResponseExpressionContext (1 -> 2 lifetime params) in /tmp/.tmprALqgp/router/lib/executor/src/headers/response.rs:53
  Struct RequestExpressionContext (1 -> 2 lifetime params) in /tmp/.tmprALqgp/router/lib/executor/src/headers/request.rs:48
  Struct ClientRequestDetails (1 -> 2 lifetime params) in /tmp/.tmprALqgp/router/lib/executor/src/execution/plan.rs:57
  Struct Executor (1 -> 2 lifetime params) in /tmp/.tmprALqgp/router/lib/executor/src/execution/plan.rs:137
  Struct QueryPlanExecutionContext (1 -> 2 lifetime params) in /tmp/.tmprALqgp/router/lib/executor/src/execution/plan.rs:64
Changelog

hive-router-plan-executor

7.0.0 - 2025-10-28

Refactoring

  • (executor, router) define ClientRequestDetails only once and avoid all clones, improve how coerce_variables is done (#532)

hive-router

0.0.16 - 2025-10-28

Refactoring

  • (executor, router) define ClientRequestDetails only once and avoid all clones, improve how coerce_variables is done (#532)


This PR was generated with release-plz.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @theguild-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request constitutes a new release across several core hive-router ecosystem packages, bringing a mix of new features, critical bug fixes, and a significant breaking change. The updates aim to enhance the router's capabilities with more flexible configuration and GraphQL federation support, while also improving the robustness of error handling. Developers should note the API breaking change in hive-router-plan-executor when upgrading.

Highlights

  • Breaking Change in hive-router-plan-executor: The hive-router-plan-executor package has a breaking API change, moving from version 5.0.0 to 6.0.0. This is due to the removal or renaming of the PlanExecutionError enum, which was previously publicly visible.
  • New Features Across Packages: Several packages introduce new features, including support for label overrides using the @override directive and enhanced configuration options. The hive-router-config and hive-router packages now allow configuration overrides via environment variables and the ability to enable/disable GraphiQL through configuration.
  • Bug Fix for Federation v1 Introspection: A bug affecting introspection for Federation v1 supergraphs has been fixed in the hive-router-query-planner and hive-router packages, improving compatibility and reliability.
  • Improved Error Handling: The hive-router-plan-executor and hive-router packages have undergone refactoring to add more context to PlanExecutionError, which should aid in debugging and error resolution.
  • Version Bumps: All affected packages (hive-router, hive-router-config, hive-router-plan-executor, hive-router-query-planner) have received version updates, reflecting the new features, bug fixes, and the breaking change.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR updates the versions of several hive-router components and their dependencies in the Cargo.lock and Cargo.toml files. It also updates the CHANGELOG.md files for each component to reflect the new versions and associated changes. The most significant change is the upgrade of hive-router-plan-executor from version 5.0.0 to 6.0.0, which includes API breaking changes. The review focuses on ensuring adherence to the performance-first style guide, particularly regarding tracing and logging in hot paths.

@github-actions
Copy link

github-actions bot commented Oct 27, 2025

k6-benchmark results

     ✓ response code was 200
     ✓ no graphql errors
     ✓ valid response structure

     █ setup

     checks.........................: 100.00% ✓ 224556      ✗ 0    
     data_received..................: 6.6 GB  218 MB/s
     data_sent......................: 88 MB   2.9 MB/s
     http_req_blocked...............: avg=3.57µs   min=701ns  med=1.72µs  max=36.24ms  p(90)=2.36µs  p(95)=2.68µs  
     http_req_connecting............: avg=849ns    min=0s     med=0s      max=2.19ms   p(90)=0s      p(95)=0s      
     http_req_duration..............: avg=19.63ms  min=2.24ms med=18.72ms max=235.95ms p(90)=26.66ms p(95)=29.72ms 
       { expected_response:true }...: avg=19.63ms  min=2.24ms med=18.72ms max=235.95ms p(90)=26.66ms p(95)=29.72ms 
     http_req_failed................: 0.00%   ✓ 0           ✗ 74872
     http_req_receiving.............: avg=181.38µs min=24.4µs med=37.96µs max=205.13ms p(90)=81µs    p(95)=364.84µs
     http_req_sending...............: avg=23.5µs   min=5.13µs med=10.34µs max=22.32ms  p(90)=15µs    p(95)=26.81µs 
     http_req_tls_handshaking.......: avg=0s       min=0s     med=0s      max=0s       p(90)=0s      p(95)=0s      
     http_req_waiting...............: avg=19.42ms  min=2.19ms med=18.62ms max=60.82ms  p(90)=26.39ms p(95)=29.39ms 
     http_reqs......................: 74872   2489.999902/s
     iteration_duration.............: avg=20.03ms  min=5.99ms med=19.07ms max=247.3ms  p(90)=27.08ms p(95)=30.21ms 
     iterations.....................: 74852   2489.334767/s
     vus............................: 50      min=50        max=50 
     vus_max........................: 50      min=50        max=50 

@github-actions
Copy link

github-actions bot commented Oct 27, 2025

🐋 This PR was built and pushed to the following Docker images:

Image Names: ghcr.io/graphql-hive/router

Platforms: linux/amd64,linux/arm64

Image Tags: ghcr.io/graphql-hive/router:pr-530 ghcr.io/graphql-hive/router:sha-b01a863

Docker metadata
{
"buildx.build.ref": "builder-8c6ae844-e50f-47b0-b702-c8ae0d832e18/builder-8c6ae844-e50f-47b0-b702-c8ae0d832e180/ivkb5w486o319qj2qwt196249",
"containerimage.descriptor": {
  "mediaType": "application/vnd.oci.image.index.v1+json",
  "digest": "sha256:d5b480f5015656023ce12be3629f14f559ae63f0097ae75ade7b9859f2ce6f06",
  "size": 1609
},
"containerimage.digest": "sha256:d5b480f5015656023ce12be3629f14f559ae63f0097ae75ade7b9859f2ce6f06",
"image.name": "ghcr.io/graphql-hive/router:pr-530,ghcr.io/graphql-hive/router:sha-b01a863"
}

@theguild-bot theguild-bot force-pushed the release-plz-2025-10-27T09-47-25Z branch 2 times, most recently from b515e08 to 71b1cf1 Compare October 28, 2025 11:07
@theguild-bot theguild-bot force-pushed the release-plz-2025-10-27T09-47-25Z branch from 71b1cf1 to 92fe132 Compare October 28, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants