Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove icons from feature tabs #5651

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Remove icons from feature tabs #5651

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
192bd78
Remove feature icons
hasparus Oct 8, 2024
c049ed0
Remove unused imports
hasparus Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions packages/web/docs/src/components/feature-tabs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import { ReactNode, useState } from 'react';

Check failure on line 1 in packages/web/docs/src/components/feature-tabs.tsx

View workflow job for this annotation

GitHub Actions / code-style / eslint-and-prettier 

'ReactNode' is defined but never used. Allowed unused vars must match /^_/u
import Image, { StaticImageData } from 'next/image';
import { ChevronDownIcon } from '@radix-ui/react-icons';
import * as Tabs from '@radix-ui/react-tabs';
import { CallToAction, Heading } from '@theguild/components';
import { cn } from '../lib';
import { ArrowIcon } from './arrow-icon';
import { Stud } from './stud';

Check failure on line 8 in packages/web/docs/src/components/feature-tabs.tsx

View workflow job for this annotation

GitHub Actions / code-style / eslint-and-prettier 

'Stud' is defined but never used. Allowed unused vars must match /^_/u
import observabilityClientsImage from '../../public/features/observability/clients.webp';
import observabilityOperationsImage from '../../public/features/observability/operations.webp';
import observabilityOverallImage from '../../public/features/observability/overall.webp';
Expand Down Expand Up @@ -155,7 +155,6 @@
<Tabs.Content value="Schema Registry" tabIndex={-1}>
<Feature
title="Schema Registry"
icon={<SchemaRegistryIcon />}
documentationLink="/docs/schema-registry"
description="Publish schemas, compose federated services, and detect backward-incompatible changes with ease."
highlights={highlights['Schema Registry']}
Expand All @@ -165,7 +164,6 @@
<Tabs.Content value="GraphQL Observability" tabIndex={-1}>
<Feature
title="GraphQL Observability"
icon={<GraphQLObservabilityIcon />}
documentationLink="/docs/schema-registry/usage-reporting"
description="Enhanced GraphQL Observability tools provide insights into API usage and user experience metrics."
highlights={highlights['GraphQL Observability']}
Expand All @@ -175,7 +173,6 @@
<Tabs.Content value="Schema Management" tabIndex={-1}>
<Feature
title="Schema Management"
icon={<SchemaManagementIcon />}
description="Evolve your GraphQL API with confidence."
highlights={highlights['Schema Management']}
setActiveHighlight={setActiveHighlight}
Expand Down Expand Up @@ -233,19 +230,17 @@
}

function Feature(props: {
icon: ReactNode;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove unused

CleanShot 2024-10-08 at 15 34 18@2x

title: string;
description: string;
highlights: Highlight[];
documentationLink?: string;
setActiveHighlight: (highlight: string) => void;
}) {
const { icon, title, description, documentationLink, highlights } = props;
const { title, description, documentationLink, highlights } = props;

return (
<div className="flex flex-col gap-6 px-4 pb-4 md:gap-12 md:pb-12 md:pl-12 md:pr-16">
<header className="flex flex-wrap items-center gap-4 md:flex-col md:items-start md:gap-6">
<Stud>{icon}</Stud>
<Heading as="h2" size="md" className="text-green-1000 max-sm:text-2xl max-sm:leading-8">
{title}
</Heading>
Expand Down
Loading