feat: Make schema file path configurable in router registry plugin #3751
Conversation
|
| @@ -76,6 +79,12 @@ impl HiveRegistry { | |||
| } | |||
| } | |||
|
|
|||
| if config.schema_file_path.is_none() { | |||
| if let Ok(schema_file_path) = env::var("HIVE_CDN_SCHEMA_FILE_PATH") { | |||
There was a problem hiding this comment.
I think you should update the docs too!
- Document new env var
HIVE_CDN_SCHEMA_FILE_PATH - Document new config option
schema_file_path - Add
schema_file_pathto the commentedrouter.yaml- not sure if this is a docs only thing or actually part of the code bootstrapping the config too?
There was a problem hiding this comment.
schema_file_path cant be configured in router.yaml, since this is not a router plugin
There was a problem hiding this comment.
did update the docs regarding the new env var
thrawny
force-pushed
the
router-registry-plugin-configurable-schema-path
branch
from
ef69936
to
8794de5
Compare
Background
Make it easier to as non root by allowing the user to specify where to download the supergraph schema file from the hive cdn. Typically, /tmp is writable and is a suitable place to download the file to. Alternatively, if using kubernetes, one could create an emptyDir volume and download the schema file to there.
Description
The change affects the router rust package, specifically the registry module.
Checklist