Detect missing DocumentNode in Apollo Server (#2979)

graphql-hive · Sep 29, 2023 · fa18b0a · fa18b0a
1 parent 951322c
commit fa18b0a
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/.changeset/fair-beds-beg.md b/.changeset/fair-beds-beg.md
@@ -0,0 +1,5 @@
+---
+'@graphql-hive/client': patch
+---
+
+Detect missing DocumentNode in Apollo Server
diff --git a/packages/libraries/client/src/apollo.ts b/packages/libraries/client/src/apollo.ts
@@ -176,6 +176,15 @@ export function hiveApollo(clientOrOptions: HiveClient | HivePluginOptions): Apo
       if (isLegacyV3) {
         return Promise.resolve({
           async willSendResponse(ctx) {
+            if (!ctx.document) {
+              const details = ctx.operationName ? `operationName: ${ctx.operationName}` : '';
+              complete(args, {
+                action: 'abort',
+                reason: 'Document is not available' + (details ? ` (${details})` : ''),
+              });
+              return;
+            }
+
             doc = ctx.document!;
             complete(args, ctx.response as any);
           },
@@ -185,7 +194,16 @@ export function hiveApollo(clientOrOptions: HiveClient | HivePluginOptions): Apo
       // v4
       return Promise.resolve({
         async willSendResponse(ctx) {
-          doc = ctx.document!;
+          if (!ctx.document) {
+            const details = ctx.operationName ? `operationName: ${ctx.operationName}` : '';
+            complete(args, {
+              action: 'abort',
+              reason: 'Document is not available' + (details ? ` (${details})` : ''),
+            });
+            return;
+          }
+
+          doc = ctx.document;
           if (ctx.response.body.kind === 'incremental') {
             complete(args, {
               action: 'abort',