Skip to content

Commit

Permalink
Revert "feat: introduce timeout to s3 read requests (#5504)"
Browse files Browse the repository at this point in the history
This reverts commit f99e58f.
  • Loading branch information
kamilkisiela authored Aug 24, 2024
1 parent f99e58f commit 2ecbf90
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions packages/services/cdn-worker/src/artifact-storage-reader.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@ type SDLArtifactTypes = `sdl${'.graphql' | '.graphqls' | ''}`;

export type ArtifactsType = SDLArtifactTypes | 'metadata' | 'services' | 'supergraph';

/** Timeout in milliseconds for S3 read calls. */
const READ_TIMEOUT_MS = 5_000;

const OperationS3BucketKeyModel = zod.tuple([
zod.string().uuid(),
zod.string().min(1),
Expand Down Expand Up @@ -88,7 +85,6 @@ export class ArtifactStorageReader {
headers: {
'X-Amz-Expires': String(presignedUrlExpirationSeconds),
},
timeout: READ_TIMEOUT_MS,
},
);

Expand Down Expand Up @@ -130,7 +126,6 @@ export class ArtifactStorageReader {
aws: {
signQuery: true,
},
timeout: READ_TIMEOUT_MS,
},
);
this.analytics?.track(
Expand Down Expand Up @@ -169,7 +164,6 @@ export class ArtifactStorageReader {
aws: {
signQuery: true,
},
timeout: READ_TIMEOUT_MS,
},
);
this.analytics?.track(
Expand Down Expand Up @@ -206,7 +200,6 @@ export class ArtifactStorageReader {
signQuery: true,
},
headers,
timeout: READ_TIMEOUT_MS,
},
);

Expand Down

0 comments on commit 2ecbf90

Please sign in to comment.