fix: correct type error as a result of removed imports #2854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added .mdx documentation for scalar types: GUID, HSLA, ISO8601Duration, LCCSubclass, Long, SESSN, UnsignedFloat, and UnsignedInt. - Resolves issue graphql-hive#2019 regarding missing scalar type documentation.
- Introduced a custom GeoJSON scalar type. - Added unit tests to ensure proper validation and functionality of the GeoJSON scalar. - Updated documentation website to reflect the new scalar type and usage. - Resolves issue graphql-hive#2061.
- Updated GeoJSON imports to use .js extensions, resolving import errors in tests. - Removed index.ts re-export of GeoJSON to reduce bundle size by approximately 4KB. - Eliminated the codegenScalarType generate function, saving an additional ~8KB. - Revised GeoJSON documentation to clarify its integration with GraphQL Codegen. - Saved ~3kb by removing the geojsonSchema from the extensions of the GeoJSON scalar. - Updated documentation to reflect the change in how the GeoJSON's json schema is accessed.
…en type - Switched validation from regex to Set lookup for performance and clarity - Tests now source from COUNTRY_CODES enum directly, ensuring full coverage - codegenScalarType now emits explicit union of allowed values instead of generic `string`
- Switched validation from regex to Set lookup for performance and clarity - Tests now source from CURRENCY_CODES enum directly, ensuring full coverage - codegenScalarType now emits explicit union of allowed values instead of generic `string`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of
the pull request.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant
motivation and context. List any dependencies that are required for this change.
Related # (issue)
Type of change
Please delete options that are not relevant.
expected)
Screenshots/Sandbox (if appropriate/relevant):
Adding links to sandbox or providing screenshots can help us understand more about this PR and take
action on it as appropriate
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can
reproduce. Please also list any relevant details for your test configuration
Test Environment:
Checklist:
CONTRIBUTING doc and the
style guidelines of this project
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose
the solution you did and what alternatives you considered, etc...