Color the row numbers for partial addition/deletions on schema proposals #7468

jdolle · 2026-01-07T02:38:32Z

Background

Partial additions/deletions did not set the color of the row number. This could make it more difficult to scan for these changes.

Description

Uses context to pass the change state to the row

gemini-code-assist · 2026-01-07T02:38:50Z

Summary of Changes

Hello @jdolle, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where row numbers for partial additions or deletions in schema proposals lacked appropriate coloring, hindering visual scanning. It introduces a new React Context to propagate change states from individual Addition and Removal components up to their parent ChangeRow. This enables the ChangeRow to apply the correct background colors to row numbers, significantly enhancing the clarity and scannability of schema diffs.

Highlights

Improved Schema Diff Readability: Row numbers for partial additions and deletions within schema proposals are now correctly colored, making these changes easier to identify at a glance.
New React Context for Change State: A new React Context, ChangeRowContext, has been introduced to effectively pass the addition and removal states down the component tree.
Dynamic Row Number Coloring: The ChangeRow component now utilizes the ChangeRowContext to dynamically apply red background for removals and green for additions to the row numbers, based on the presence of Removal or Addition components within its children.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request correctly implements coloring for row numbers in partial additions/deletions by using a React context to communicate changes from child components (Addition/Removal) up to the parent ChangeRow. My main feedback concerns the use of useEffect to trigger a state update in the parent, which causes an extra render cycle and goes against a repository style guide rule. I've left a comment with more details.

gemini-code-assist · 2026-01-07T02:40:07Z

packages/web/app/src/components/target/proposals/schema-diff/components.tsx

+  useEffect(() => {
+    if (!change.removal) {
+      setRemoved(true);
+    }
+  }, [change.removal]);


This useEffect triggers a re-render of the parent component, which can impact performance and goes against our style guide rule to 'avoid setting state from useEffect' (line 19). The same logic is duplicated in the Addition component.

Please consider if there's an alternative to this pattern that avoids the extra render cycle. If the pattern is kept, the duplicated logic should be extracted into a custom hook for better maintainability.

References

The style guide advises to 'avoid setting state from useEffect instead of deriving it'. The current implementation uses useEffect to set state on a parent component, which causes an extra render and is a pattern to be avoided if a better alternative exists. ^(link)

This should only trigger once on the parent and although this can be calculated in the parent, it's much more complicated since which row something ends up on is based on how we render it.

github-actions · 2026-01-07T02:40:25Z

🚀 Snapshot Release (`alpha`)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package	Version	Info
`@graphql-hive/apollo`	`0.46.0-alpha-20260107023933-566b72af303443d7b17b48e48af7405b091317c2`	npm ↗︎ unpkg ↗︎
`@graphql-hive/cli`	`0.57.0-alpha-20260107023933-566b72af303443d7b17b48e48af7405b091317c2`	npm ↗︎ unpkg ↗︎
`@graphql-hive/core`	`0.19.0-alpha-20260107023933-566b72af303443d7b17b48e48af7405b091317c2`	npm ↗︎ unpkg ↗︎
`@graphql-hive/envelop`	`0.40.1-alpha-20260107023933-566b72af303443d7b17b48e48af7405b091317c2`	npm ↗︎ unpkg ↗︎
`@graphql-hive/yoga`	`0.46.1-alpha-20260107023933-566b72af303443d7b17b48e48af7405b091317c2`	npm ↗︎ unpkg ↗︎
`hive`	`8.14.0-alpha-20260107023933-566b72af303443d7b17b48e48af7405b091317c2`	npm ↗︎ unpkg ↗︎
`hive-apollo-router-plugin`	`2.3.6-alpha-20260107023933-566b72af303443d7b17b48e48af7405b091317c2`	npm ↗︎ unpkg ↗︎
`hive-console-sdk-rs`	`0.2.3-alpha-20260107023933-566b72af303443d7b17b48e48af7405b091317c2`	npm ↗︎ unpkg ↗︎

github-actions · 2026-01-07T02:40:41Z

📚 Storybook Deployment

The latest changes are available as preview in: https://pr-7468.hive-storybook.pages.dev

github-actions · 2026-01-07T02:44:38Z

💻 Website Preview

The latest changes are available as preview in: https://pr-7468.hive-landing-page.pages.dev

github-actions · 2026-01-07T02:47:09Z

🐋 This PR was built and pushed to the following Docker images:

Targets: build

Platforms: linux/amd64

Image Tag: 566b72af303443d7b17b48e48af7405b091317c2

Color the row numbers for partial addition/deletions on schema proposals

566b72a

jdolle self-assigned this Jan 7, 2026

gemini-code-assist bot reviewed Jan 7, 2026

View reviewed changes

github-actions bot deployed to preview January 7, 2026 02:40 View deployment

github-actions bot deployed to preview January 7, 2026 02:44 View deployment

n1ru4l approved these changes Jan 7, 2026

View reviewed changes

jdolle merged commit 7dea5b1 into main Jan 7, 2026
26 checks passed

jdolle deleted the change-row-number-color branch January 7, 2026 17:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Color the row numbers for partial addition/deletions on schema proposals #7468

Color the row numbers for partial addition/deletions on schema proposals #7468

jdolle commented Jan 7, 2026

Uh oh!

gemini-code-assist bot commented Jan 7, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Jan 7, 2026

Uh oh!

jdolle Jan 7, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 7, 2026

Uh oh!

github-actions bot commented Jan 7, 2026

Uh oh!

github-actions bot commented Jan 7, 2026

Uh oh!

github-actions bot commented Jan 7, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Color the row numbers for partial addition/deletions on schema proposals #7468

Color the row numbers for partial addition/deletions on schema proposals #7468

Conversation

jdolle commented Jan 7, 2026

Background

Description

Uh oh!

gemini-code-assist bot commented Jan 7, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

jdolle Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 7, 2026

🚀 Snapshot Release (alpha)

Uh oh!

github-actions bot commented Jan 7, 2026

📚 Storybook Deployment

Uh oh!

github-actions bot commented Jan 7, 2026

💻 Website Preview

Uh oh!

github-actions bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

jdolle Jan 7, 2026 •

edited

Loading

🚀 Snapshot Release (`alpha`)

github-actions bot commented Jan 7, 2026 •

edited

Loading