-
Notifications
You must be signed in to change notification settings - Fork 125
docs: add l2 cache documentation for persisted documents #7463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @adambenhassen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces new documentation to guide users on implementing Layer 2 (L2) caching for persisted documents within the Hive client. This feature is particularly beneficial for serverless or multi-instance deployments, allowing for shared and more resilient caching mechanisms beyond the default in-memory cache. The added content includes practical code examples for both Yoga and Apollo Server integrations, along with explanations of key configuration parameters. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds documentation for configuring a Layer 2 cache for persisted documents with GraphQL Yoga and Apollo Server. The changes are clear and provide useful examples. I've made a couple of suggestions to improve consistency between the examples and ensure the documentation is complete for both integrations.
| ttlSeconds: 3600, | ||
| notFoundTtlSeconds: 60 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ] | ||
| }) | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with the GraphQL Yoga example and for completeness, it would be beneficial to add the lookup flow description and the options table here as well.
The lookup flow is: **L1 (memory) -> L2 (Redis/external) -> CDN**
| Option | Description |
| -------------------- | ----------------------------------------------------------------------------------------------- |
| `cache.get` | Async function to get a value from the cache. Returns `null` for cache miss. |
| `cache.set` | Async function to set a value in the cache. Receives an optional `ttl` option. |
| `ttlSeconds` | TTL in seconds for successfully found documents. |
| `notFoundTtlSeconds` | TTL in seconds for not-found documents (negative caching). Set to `0` to disable. Default: `60` |
| `waitUntil` | Optional function for serverless environments to ensure cache writes complete. |
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-hive/apollo |
0.46.0-alpha-20260107121417-6c5aa0758500430b15a315c65892035a57ad9ebe |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/cli |
0.57.0-alpha-20260107121417-6c5aa0758500430b15a315c65892035a57ad9ebe |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/core |
0.19.0-alpha-20260107121417-6c5aa0758500430b15a315c65892035a57ad9ebe |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/envelop |
0.40.1-alpha-20260107121417-6c5aa0758500430b15a315c65892035a57ad9ebe |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/yoga |
0.46.1-alpha-20260107121417-6c5aa0758500430b15a315c65892035a57ad9ebe |
npm ↗︎ unpkg ↗︎ |
hive |
8.14.0-alpha-20260107121417-6c5aa0758500430b15a315c65892035a57ad9ebe |
npm ↗︎ unpkg ↗︎ |
hive-apollo-router-plugin |
2.3.6-alpha-20260107121417-6c5aa0758500430b15a315c65892035a57ad9ebe |
npm ↗︎ unpkg ↗︎ |
hive-console-sdk-rs |
0.2.3-alpha-20260107121417-6c5aa0758500430b15a315c65892035a57ad9ebe |
npm ↗︎ unpkg ↗︎ |
📚 Storybook DeploymentThe latest changes are available as preview in: https://pr-7463.hive-storybook.pages.dev |
💻 Website PreviewThe latest changes are available as preview in: https://pr-7463.hive-landing-page.pages.dev |
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tag: |
6c5aa07 to
3d4de8f
Compare
Background
Description
Checklist