-
Notifications
You must be signed in to change notification settings - Fork 125
fix(apollo): fix l2 cache config and add waitUntil support #7462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @adambenhassen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the stability and functionality of Apollo Server's integration with Layer 2 (L2) persisted document caching. It addresses a critical bug in the cache configuration that could lead to crashes and introduces Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes a non-null assertion bug in the L2 cache configuration for Apollo and adds support for waitUntil propagation from the context. The changes are well-implemented. I have one suggestion to simplify the logic for setting the layer2Cache, making it more direct and readable.
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-hive/apollo |
0.47.0-alpha-20260107122401-47a7c87bdb6c6bfe5d80ea4b8ce0c165adc0f0df |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/cli |
0.57.1-alpha-20260107122401-47a7c87bdb6c6bfe5d80ea4b8ce0c165adc0f0df |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/core |
0.20.0-alpha-20260107122401-47a7c87bdb6c6bfe5d80ea4b8ce0c165adc0f0df |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/envelop |
0.40.2-alpha-20260107122401-47a7c87bdb6c6bfe5d80ea4b8ce0c165adc0f0df |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/yoga |
0.47.0-alpha-20260107122401-47a7c87bdb6c6bfe5d80ea4b8ce0c165adc0f0df |
npm ↗︎ unpkg ↗︎ |
📚 Storybook DeploymentThe latest changes are available as preview in: https://pr-7462.hive-storybook.pages.dev |
💻 Website PreviewThe latest changes are available as preview in: https://pr-7462.hive-landing-page.pages.dev |
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tag: |
dd6f88d to
3d224b6
Compare
08f70fd to
47a7c87
Compare
Description
Fixes Apollo Server integration for L2 cache: