Skip to content

Conversation

@adambenhassen
Copy link
Collaborator

Description

Fixes Apollo Server integration for L2 cache:

  • Fix non-null assertion bug where persistedDocumentsCache! could crash if user provides layer2Cache but ctx.cache is undefined
  • Add waitUntil propagation from context

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @adambenhassen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the stability and functionality of Apollo Server's integration with Layer 2 (L2) persisted document caching. It addresses a critical bug in the cache configuration that could lead to crashes and introduces waitUntil support, which is vital for ensuring proper asynchronous operation completion in serverless environments. These changes collectively improve the robustness and performance of GraphQL Hive's Apollo plugin.

Highlights

  • L2 Cache Configuration Fix: Resolved a potential runtime error in Apollo Server's Layer 2 (L2) cache integration. Previously, a non-null assertion could cause a crash if persistedDocumentsCache was provided but the underlying context cache was undefined. The configuration logic has been refactored to handle this gracefully.
  • WaitUntil Support: Added support for waitUntil propagation from the Apollo context. This enhancement is crucial for serverless environments, allowing asynchronous operations (like cache writes) to complete before the serverless function's execution context is frozen, improving reliability and data consistency.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes a non-null assertion bug in the L2 cache configuration for Apollo and adds support for waitUntil propagation from the context. The changes are well-implemented. I have one suggestion to simplify the logic for setting the layer2Cache, making it more direct and readable.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-hive/apollo 0.47.0-alpha-20260107122401-47a7c87bdb6c6bfe5d80ea4b8ce0c165adc0f0df npm ↗︎ unpkg ↗︎
@graphql-hive/cli 0.57.1-alpha-20260107122401-47a7c87bdb6c6bfe5d80ea4b8ce0c165adc0f0df npm ↗︎ unpkg ↗︎
@graphql-hive/core 0.20.0-alpha-20260107122401-47a7c87bdb6c6bfe5d80ea4b8ce0c165adc0f0df npm ↗︎ unpkg ↗︎
@graphql-hive/envelop 0.40.2-alpha-20260107122401-47a7c87bdb6c6bfe5d80ea4b8ce0c165adc0f0df npm ↗︎ unpkg ↗︎
@graphql-hive/yoga 0.47.0-alpha-20260107122401-47a7c87bdb6c6bfe5d80ea4b8ce0c165adc0f0df npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

📚 Storybook Deployment

The latest changes are available as preview in: https://pr-7462.hive-storybook.pages.dev

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

💻 Website Preview

The latest changes are available as preview in: https://pr-7462.hive-landing-page.pages.dev

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

🐋 This PR was built and pushed to the following Docker images:

Targets: build

Platforms: linux/amd64

Image Tag: 47a7c87bdb6c6bfe5d80ea4b8ce0c165adc0f0df

@adambenhassen adambenhassen force-pushed the adam/console-1275-fixes branch from 08f70fd to 47a7c87 Compare January 7, 2026 12:22
@adambenhassen adambenhassen merged commit 60133a4 into main Jan 7, 2026
26 checks passed
@adambenhassen adambenhassen deleted the adam/console-1275-fixes branch January 7, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants